From 1da827203aec3db36b6a834f5e11c2cb3fc578ad Mon Sep 17 00:00:00 2001
From: Rene Steen <rene.steen@steen-ie.de>
Date: Mon, 28 Jul 2025 22:52:59 +0200
Subject: [PATCH] fix/seagate exos corvault (#3350)

* added seagate exos corvault 4U106

* remove trailing line

* added empty line

* only lowercase letters in slug

* slug should contain full manufacturer

* * added weight and airflow property
* moved interfaces and PSU to module definitions

* added empty line at the end

* added Artesyn PSU used by seagate corvault

* remove whitespace

* Add is_full_depth property to Seagate Exos CORVAULT controller

* update filename

* module placeholders dont work for device bays

* subdevice definition was missing and needs to be set to parent

* all controller port names should be lower case

* move rj45 port to interface as it can be assigned an IP and has a webinterface

* remove comment

---------

Co-authored-by: Rene Steen <steen.rene@indivumed.com>
---
 .../Seagate Systems/Exos-CORVAULT-4U106.yaml  |  1 +
 .../exos-corvault-sas-controller.yaml         | 23 +++++++++----------
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/device-types/Seagate Systems/Exos-CORVAULT-4U106.yaml b/device-types/Seagate Systems/Exos-CORVAULT-4U106.yaml
index f75ae1e5..f06ac396 100644
--- a/device-types/Seagate Systems/Exos-CORVAULT-4U106.yaml	
+++ b/device-types/Seagate Systems/Exos-CORVAULT-4U106.yaml	
@@ -9,6 +9,7 @@ is_full_depth: true
 weight: 131.5
 weight_unit: kg
 description: '[Seagate Exos CORVAULT 4U106](https://www.seagate.com/products/storage/data-storage-systems/corvault/4U106/)'
+subdevice_role: parent
 module-bays:
   - name: PSU1
     position: '1'
diff --git a/device-types/Seagate Systems/exos-corvault-sas-controller.yaml b/device-types/Seagate Systems/exos-corvault-sas-controller.yaml
index 306ba769..8407f74d 100644
--- a/device-types/Seagate Systems/exos-corvault-sas-controller.yaml	
+++ b/device-types/Seagate Systems/exos-corvault-sas-controller.yaml	
@@ -8,20 +8,19 @@ u_height: 0
 is_full_depth: true
 subdevice_role: child
 interfaces:
-  - name: SAS {module}0
+  - name: SAS 0
     type: other #SFF-8644
-  - name: SAS {module}1
+  - name: SAS 1
     type: other #SFF-8644
-  - name: SAS {module}2
+  - name: SAS 2
     type: other #SFF-8644
-  - name: SAS {module}3
+  - name: SAS 3
     type: other #SFF-8644
-
-console-ports:
-  - name: manufacturer-do-not-use-{module}
-    type: usb-micro-a
-  - name: Serial{module}
-    type: usb-micro-a
-  - name: eth-{module}
-    type: rj-45
+  - name: management
+    type: 1000base-t
     mgmt_only: true
+console-ports:
+  - name: manufacturer-do-not-use
+    type: usb-micro-a
+  - name: serial
+    type: usb-micro-a