From 58fcce3deaa02407af8c9f12f50e78769a0e91db Mon Sep 17 00:00:00 2001
From: Joe Nichols <11560185+nichols-356@users.noreply.github.com>
Date: Thu, 2 Jul 2020 06:46:45 -0400
Subject: [PATCH] Palo Alto 5200 series fixes (#159)

* palo alto 5200 series fixes
* fix interface types
* add part numbers
---
 device-types/Palo Alto/PA-5220.yaml | 72 +++++++++++++------------
 device-types/Palo Alto/PA-5250.yaml | 83 +++++++++++++++--------------
 device-types/Palo Alto/PA-5260.yaml | 83 +++++++++++++++--------------
 device-types/Palo Alto/PA-5280.yaml | 83 +++++++++++++++--------------
 4 files changed, 168 insertions(+), 153 deletions(-)

diff --git a/device-types/Palo Alto/PA-5220.yaml b/device-types/Palo Alto/PA-5220.yaml
index b61f595b..41d7c373 100644
--- a/device-types/Palo Alto/PA-5220.yaml	
+++ b/device-types/Palo Alto/PA-5220.yaml	
@@ -1,103 +1,109 @@
 manufacturer: Palo Alto
 model: PA-5220
 slug: pa-5220
+part_number: PA-5220
 u_height: 3
 is_full_depth: true
 console-ports:
 - name: console
   type: rj-45
 power-ports:
-- name: PSU1
+- name: PS1
   type: iec-60320-c14
-  maximum_draw: 870
-- name: PSU2
+  maximum_draw: 685
+  allocated_draw: 571
+- name: PS2
   type: iec-60320-c14
-  maximum_draw: 870
+  maximum_draw: 685
+  allocated_draw: 571
 interfaces:
-- name: '1'
+- name: ethernet1/1
   type: 10gbase-t
   mgmt_only: false
-- name: '2'
+- name: ethernet1/2
   type: 10gbase-t
   mgmt_only: false
-- name: '3'
+- name: ethernet1/3
   type: 10gbase-t
   mgmt_only: false
-- name: '4'
+- name: ethernet1/4
   type: 10gbase-t
   mgmt_only: false
-- name: '5'
+- name: ethernet1/5
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '6'
+- name: ethernet1/6
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '7'
+- name: ethernet1/7
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '8'
+- name: ethernet1/8
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '9'
+- name: ethernet1/9
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '10'
+- name: ethernet1/10
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '11'
+- name: ethernet1/11
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '12'
+- name: ethernet1/12
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '13'
+- name: ethernet1/13
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '14'
+- name: ethernet1/14
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '15'
+- name: ethernet1/15
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '16'
+- name: ethernet1/16
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '17'
+- name: ethernet1/17
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '18'
+- name: ethernet1/18
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '19'
+- name: ethernet1/19
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '20'
+- name: ethernet1/20
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '21'
+- name: ethernet1/21
   type: 40gbase-x-qsfpp
   mgmt_only: false
-- name: '22'
+- name: ethernet1/22
   type: 40gbase-x-qsfpp
   mgmt_only: false
-- name: '23'
+- name: ethernet1/23
   type: 40gbase-x-qsfpp
   mgmt_only: false
-- name: '24'
+- name: ethernet1/24
   type: 40gbase-x-qsfpp
   mgmt_only: false
-- name: AUX-1
+- name: aux-1
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: AUX-2
+- name: aux-2
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: HA1-A
+- name: ha1-a
   type: 1000base-t
   mgmt_only: false
-- name: HA1-B
+- name: ha1-b
   type: 1000base-t
   mgmt_only: false
-- name: MGT
+- name: hsci
+  type: 40gbase-x-qsfpp
+  mgmt_only: false
+- name: management
   type: 1000base-t
   mgmt_only: true
diff --git a/device-types/Palo Alto/PA-5250.yaml b/device-types/Palo Alto/PA-5250.yaml
index f93908bf..f3919e11 100644
--- a/device-types/Palo Alto/PA-5250.yaml	
+++ b/device-types/Palo Alto/PA-5250.yaml	
@@ -1,106 +1,109 @@
 manufacturer: Palo Alto
 model: PA-5250
 slug: pa-5250
+part_number: PA-5250
 u_height: 3
 is_full_depth: true
 console-ports:
 - name: console
   type: rj-45
 power-ports:
-- name: PSU1
+- name: PS1
   type: iec-60320-c14
-  maximum_draw: 870
-- name: PSU2
+  maximum_draw: 685
+  allocated_draw: 571
+- name: PS2
   type: iec-60320-c14
-  maximum_draw: 870
+  maximum_draw: 685
+  allocated_draw: 571
 interfaces:
-- name: '1'
-  type: 1000base-t
+- name: ethernet1/1
+  type: 10gbase-t
   mgmt_only: false
-- name: '2'
-  type: 1000base-t
+- name: ethernet1/2
+  type: 10gbase-t
   mgmt_only: false
-- name: '3'
-  type: 1000base-t
+- name: ethernet1/3
+  type: 10gbase-t
   mgmt_only: false
-- name: '4'
-  type: 1000base-t
+- name: ethernet1/4
+  type: 10gbase-t
   mgmt_only: false
-- name: '5'
+- name: ethernet1/5
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '6'
+- name: ethernet1/6
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '7'
+- name: ethernet1/7
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '8'
+- name: ethernet1/8
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '9'
+- name: ethernet1/9
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '10'
+- name: ethernet1/10
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '11'
+- name: ethernet1/11
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '12'
+- name: ethernet1/12
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '13'
+- name: ethernet1/13
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '14'
+- name: ethernet1/14
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '15'
+- name: ethernet1/15
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '16'
+- name: ethernet1/16
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '17'
+- name: ethernet1/17
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '18'
+- name: ethernet1/18
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '19'
+- name: ethernet1/19
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '20'
+- name: ethernet1/20
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '21'
+- name: ethernet1/21
   type: 100gbase-x-qsfp28
   mgmt_only: false
-- name: '22'
+- name: ethernet1/22
   type: 100gbase-x-qsfp28
   mgmt_only: false
-- name: '23'
+- name: ethernet1/23
   type: 100gbase-x-qsfp28
   mgmt_only: false
-- name: '24'
+- name: ethernet1/24
   type: 100gbase-x-qsfp28
   mgmt_only: false
-- name: AUX-1
+- name: aux-1
   type: 10gbase-x-sfpp
-  mgmt_only: true
-- name: AUX-2
+  mgmt_only: false
+- name: aux-2
   type: 10gbase-x-sfpp
-  mgmt_only: true
-- name: HA1-A
+  mgmt_only: false
+- name: ha1-a
   type: 1000base-t
   mgmt_only: false
-- name: HA1-B
+- name: ha1-b
   type: 1000base-t
   mgmt_only: false
-- name: HSCI
+- name: hsci
   type: 100gbase-x-qsfp28
   mgmt_only: false
-- name: MGT
+- name: management
   type: 1000base-t
   mgmt_only: true
diff --git a/device-types/Palo Alto/PA-5260.yaml b/device-types/Palo Alto/PA-5260.yaml
index 0b824750..8cad56ac 100644
--- a/device-types/Palo Alto/PA-5260.yaml	
+++ b/device-types/Palo Alto/PA-5260.yaml	
@@ -1,106 +1,109 @@
 manufacturer: Palo Alto
 model: PA-5260
 slug: pa-5260
+part_number: PA-5260
 u_height: 3
 is_full_depth: true
 console-ports:
 - name: console
   type: rj-45
 power-ports:
-- name: PSU1
+- name: PS1
   type: iec-60320-c14
-  maximum_draw: 870
-- name: PSU2
+  maximum_draw: 685
+  allocated_draw: 571
+- name: PS2
   type: iec-60320-c14
-  maximum_draw: 870
+  maximum_draw: 685
+  allocated_draw: 571
 interfaces:
-- name: '1'
-  type: 1000base-t
+- name: ethernet1/1
+  type: 10gbase-t
   mgmt_only: false
-- name: '2'
-  type: 1000base-t
+- name: ethernet1/2
+  type: 10gbase-t
   mgmt_only: false
-- name: '3'
-  type: 1000base-t
+- name: ethernet1/3
+  type: 10gbase-t
   mgmt_only: false
-- name: '4'
-  type: 1000base-t
+- name: ethernet1/4
+  type: 10gbase-t
   mgmt_only: false
-- name: '5'
+- name: ethernet1/5
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '6'
+- name: ethernet1/6
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '7'
+- name: ethernet1/7
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '8'
+- name: ethernet1/8
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '9'
+- name: ethernet1/9
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '10'
+- name: ethernet1/10
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '11'
+- name: ethernet1/11
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '12'
+- name: ethernet1/12
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '13'
+- name: ethernet1/13
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '14'
+- name: ethernet1/14
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '15'
+- name: ethernet1/15
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '16'
+- name: ethernet1/16
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '17'
+- name: ethernet1/17
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '18'
+- name: ethernet1/18
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '19'
+- name: ethernet1/19
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '20'
+- name: ethernet1/20
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '21'
+- name: ethernet1/21
   type: 100gbase-x-qsfp28
   mgmt_only: false
-- name: '22'
+- name: ethernet1/22
   type: 100gbase-x-qsfp28
   mgmt_only: false
-- name: '23'
+- name: ethernet1/23
   type: 100gbase-x-qsfp28
   mgmt_only: false
-- name: '24'
+- name: ethernet1/24
   type: 100gbase-x-qsfp28
   mgmt_only: false
-- name: AUX-1
+- name: aux-1
   type: 10gbase-x-sfpp
-  mgmt_only: true
-- name: AUX-2
+  mgmt_only: false
+- name: aux-2
   type: 10gbase-x-sfpp
-  mgmt_only: true
-- name: HA1-A
+  mgmt_only: false
+- name: ha1-a
   type: 1000base-t
   mgmt_only: false
-- name: HA1-B
+- name: ha1-b
   type: 1000base-t
   mgmt_only: false
-- name: HSCI
+- name: hsci
   type: 100gbase-x-qsfp28
   mgmt_only: false
-- name: MGT
+- name: management
   type: 1000base-t
   mgmt_only: true
diff --git a/device-types/Palo Alto/PA-5280.yaml b/device-types/Palo Alto/PA-5280.yaml
index 8befe3bd..c3a0b7b9 100644
--- a/device-types/Palo Alto/PA-5280.yaml	
+++ b/device-types/Palo Alto/PA-5280.yaml	
@@ -1,106 +1,109 @@
 manufacturer: Palo Alto
 model: PA-5280
 slug: pa-5280
+part_number: PA-5280
 u_height: 3
 is_full_depth: true
 console-ports:
 - name: console
   type: rj-45
 power-ports:
-- name: PSU1
+- name: PS1
   type: iec-60320-c14
-  maximum_draw: 870
-- name: PSU2
+  maximum_draw: 685
+  allocated_draw: 571
+- name: PS2
   type: iec-60320-c14
-  maximum_draw: 870
+  maximum_draw: 685
+  allocated_draw: 571
 interfaces:
-- name: '1'
-  type: 1000base-t
+- name: ethernet1/1
+  type: 10gbase-t
   mgmt_only: false
-- name: '2'
-  type: 1000base-t
+- name: ethernet1/2
+  type: 10gbase-t
   mgmt_only: false
-- name: '3'
-  type: 1000base-t
+- name: ethernet1/3
+  type: 10gbase-t
   mgmt_only: false
-- name: '4'
-  type: 1000base-t
+- name: ethernet1/4
+  type: 10gbase-t
   mgmt_only: false
-- name: '5'
+- name: ethernet1/5
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '6'
+- name: ethernet1/6
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '7'
+- name: ethernet1/7
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '8'
+- name: ethernet1/8
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '9'
+- name: ethernet1/9
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '10'
+- name: ethernet1/10
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '11'
+- name: ethernet1/11
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '12'
+- name: ethernet1/12
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '13'
+- name: ethernet1/13
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '14'
+- name: ethernet1/14
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '15'
+- name: ethernet1/15
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '16'
+- name: ethernet1/16
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '17'
+- name: ethernet1/17
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '18'
+- name: ethernet1/18
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '19'
+- name: ethernet1/19
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '20'
+- name: ethernet1/20
   type: 10gbase-x-sfpp
   mgmt_only: false
-- name: '21'
+- name: ethernet1/21
   type: 100gbase-x-qsfp28
   mgmt_only: false
-- name: '22'
+- name: ethernet1/22
   type: 100gbase-x-qsfp28
   mgmt_only: false
-- name: '23'
+- name: ethernet1/23
   type: 100gbase-x-qsfp28
   mgmt_only: false
-- name: '24'
+- name: ethernet1/24
   type: 100gbase-x-qsfp28
   mgmt_only: false
-- name: AUX-1
+- name: aux-1
   type: 10gbase-x-sfpp
-  mgmt_only: true
-- name: AUX-2
+  mgmt_only: false
+- name: aux-2
   type: 10gbase-x-sfpp
-  mgmt_only: true
-- name: HA1-A
+  mgmt_only: false
+- name: ha1-a
   type: 1000base-t
   mgmt_only: false
-- name: HA1-B
+- name: ha1-b
   type: 1000base-t
   mgmt_only: false
-- name: HSCI
+- name: hsci
   type: 100gbase-x-qsfp28
   mgmt_only: false
-- name: MGT
+- name: management
   type: 1000base-t
   mgmt_only: true