From bc900787be100399512579bdb2c06d5664bc2c4e Mon Sep 17 00:00:00 2001
From: Sjur Fredriksen <sjur.fredriksen@nrk.no>
Date: Mon, 14 Oct 2024 22:10:37 +0200
Subject: [PATCH] add dell powerscale H700 (#2156)

* add dell powerscale H700

* fixes after tests

* fixes after tests

* Rename Powerscale-H700-Chassis.yml to Powerscale-H700-Chassis.yaml

* Updated Powerscale-H700.yaml

Converted power ports to Module bays

* Update PowerScale-H700.yaml

Fixed merge check error

---------

Co-authored-by: Harry
---
 .../Dell/PowerScale-H700-Chassis.yaml         | 21 ++++++++++++
 device-types/Dell/PowerScale-H700.yaml        | 33 +++++++++----------
 2 files changed, 37 insertions(+), 17 deletions(-)
 create mode 100644 device-types/Dell/PowerScale-H700-Chassis.yaml

diff --git a/device-types/Dell/PowerScale-H700-Chassis.yaml b/device-types/Dell/PowerScale-H700-Chassis.yaml
new file mode 100644
index 00000000..b514011a
--- /dev/null
+++ b/device-types/Dell/PowerScale-H700-Chassis.yaml
@@ -0,0 +1,21 @@
+---
+manufacturer: Dell
+model: Powerscale H700 Chassis
+slug: dell-powerscale-h700-chassis
+comments: '[Dell Powerscale H700 Specification Sheet](https://www.delltechnologies.com/asset/en-us/products/storage/technical-support/h16071-ss-powerscale-hybrid-nodes.pdf)'
+u_height: 4.0
+is_full_depth: true
+subdevice_role: parent
+airflow: front-to-rear
+weight: 118.0
+weight_unit: kg
+is_powered: false
+device-bays:
+  - name: Node 1
+    label: '1'
+  - name: Node 2
+    label: '2'
+  - name: Node 3
+    label: '3'
+  - name: Node 4
+    label: '4'
diff --git a/device-types/Dell/PowerScale-H700.yaml b/device-types/Dell/PowerScale-H700.yaml
index b22ac989..f217427f 100644
--- a/device-types/Dell/PowerScale-H700.yaml
+++ b/device-types/Dell/PowerScale-H700.yaml
@@ -1,26 +1,18 @@
 ---
 manufacturer: Dell
-model: PowerScale H700
+model: Powerscale H700
 slug: dell-powerscale-h700
-u_height: 4
-is_full_depth: true
-airflow: front-to-rear
-part_number: h700
-comments: '[Dell PowerScale H700 Specification Sheet](https://www.delltechnologies.com/asset/en-us/products/storage/technical-support/h16071-ss-powerscale-hybrid-nodes.pdf)'
-#max weight - 2x processor, 2x PSU, 60xHDD
-weight: 118
-weight_unit: kg
+comments: '[Dell Powerscale H700 Specification Sheet](https://www.delltechnologies.com/asset/en-us/products/storage/technical-support/h16071-ss-powerscale-hybrid-nodes.pdf)'
+u_height: 0.0
+is_full_depth: false
+subdevice_role: child
 console-ports:
-  - name: Serial
+  - name: Console
     type: de-9
-module-bays:
-  - name: PSU1
-    position: PSU1
-    type: iec-60320-c14
-  - name: PSU2
-    position: PSU2
-    type: iec-60320-c14
 interfaces:
+  - name: Management
+    type: 1000base-t
+    mgmt_only: true
   - name: Gig-E 1
     type: 32gfc-sfp28
   - name: Gig-E 2
@@ -29,3 +21,10 @@ interfaces:
     type: 128gfc-qsfp28
   - name: Gig-E 4
     type: 128gfc-qsfp28
+module-bays:
+  - name: PSU 1
+    position: PSU1
+  - name: PCIe1
+    position: PCIe1
+  - name: PCIe2
+    position: PCIe2