Module-Types - Model Name Fixes (#1063)

* Updated module types to have proper model names

* Updated Aruba module-types so that the model name is accurate

* fixing Broadcom part number

* updated comments to description

* fixed checkpoint model names

* moved generic keystone modules to a generic module folder

* according to FS datasheets, each item has an Item ID (unique part number) and their associated model name

* fixing the other module types

* removed mgmt_false definition

* removed newlines

* removed extra definitions

* fixed description, changed to comments

* fixing fs part numbers to be strings

* removed extra newlines

* Removed extra newlines

* reemoved blank definition

module-types/Generic/LC-Keystone.yaml

@@ -0,0 +1,13 @@
+---
+manufacturer: Generic
+model: Keystone LC Fiber
+part_number: Keystone-LC-Fiber
+front-ports:
+  - name: '{module}-LC'
+    type: lc
+    rear_port: '{module}-LC'
+    rear_port_position: 1
+rear-ports:
+  - name: '{module}-LC'
+    type: lc
+    positions: 1

module-types/Generic/RJ45-Keystone.yaml

@@ -0,0 +1,13 @@
+---
+manufacturer: Generic
+model: Keystone RJ45
+part_number: Keystone-RJ45
+front-ports:
+  - name: '{module}-RJ45'
+    type: 8p8c
+    rear_port: '{module}-RJ45'
+    rear_port_position: 1
+rear-ports:
+  - name: '{module}-RJ45'
+    type: 8p8c
+    positions: 1