feat(settings): remove 'auto' preset and default to 'best' to (#16)

src/main/download-engine/format-utils.ts

@@ -6,7 +6,6 @@ import type {
 } from '../../shared/types'
 
 const qualityPresetToVideoHeight: Record<OneClickQualityPreset, number | null> = {
-  auto: null,
   best: null,
   good: 1080,
   normal: 720,
@@ -15,7 +14,6 @@ const qualityPresetToVideoHeight: Record<OneClickQualityPreset, number | null> =
 }
 
 const qualityPresetToAudioAbr: Record<OneClickQualityPreset, number | null> = {
-  auto: null,
   best: 320,
   good: 256,
   normal: 192,
@@ -187,7 +185,7 @@ export const resolveSelectedFormat = (
     return directMatch
   }
 
-  const preset = settings.oneClickQuality ?? 'auto'
+  const preset = settings.oneClickQuality ?? 'best'
 
   if (options.type === 'video') {
     const videoFormats = formats.filter(

src/renderer/src/components/video/FormatSelector.tsx

@@ -12,7 +12,6 @@ import { useTranslation } from 'react-i18next'
 import type { OneClickQualityPreset, VideoFormat } from '../../../../shared/types'
 
 const qualityPresetToVideoHeight: Record<OneClickQualityPreset, number | null> = {
-  auto: null,
   best: null,
   good: 1080,
   normal: 720,

src/renderer/src/pages/Home.tsx

@@ -42,7 +42,6 @@ import {
 } from '../store/video'
 
 const qualityPresetToVideoHeight: Record<OneClickQualityPreset, number | null> = {
-  auto: null,
   best: null,
   good: 1080,
   normal: 720,
@@ -51,7 +50,6 @@ const qualityPresetToVideoHeight: Record<OneClickQualityPreset, number | null> =
 }
 
 const qualityPresetToAudioAbr: Record<OneClickQualityPreset, number | null> = {
-  auto: null,
   best: 320,
   good: 256,
   normal: 192,
@@ -72,7 +70,7 @@ const dedupe = (candidates: Array<string | undefined>): string[] => {
 }
 
 const getQualityPreset = (settings: AppSettings): OneClickQualityPreset =>
-  settings.oneClickQuality ?? 'auto'
+  settings.oneClickQuality ?? 'best'
 
 const buildAudioSelectors = (preset: OneClickQualityPreset): string[] => {
   if (preset === 'worst') {

src/renderer/src/pages/Settings.tsx

@@ -235,9 +235,6 @@ export function Settings() {
                           <SelectValue />
                         </SelectTrigger>
                         <SelectContent>
-                          <SelectItem value="auto">
-                            {t('settings.oneClickQualityOptions.auto')}
-                          </SelectItem>
                           <SelectItem value="best">
                             {t('settings.oneClickQualityOptions.best')}
                           </SelectItem>

src/shared/types/index.ts

@@ -172,7 +172,7 @@ export interface PlaylistDownloadResult {
 }
 
 // Settings types
-export type OneClickQualityPreset = 'auto' | 'best' | 'good' | 'normal' | 'bad' | 'worst'
+export type OneClickQualityPreset = 'best' | 'good' | 'normal' | 'bad' | 'worst'
 
 export interface AppSettings {
   downloadPath: string
@@ -206,7 +206,7 @@ export const defaultSettings: AppSettings = {
   theme: 'system',
   oneClickDownload: false,
   oneClickDownloadType: 'video',
-  oneClickQuality: 'auto',
+  oneClickQuality: 'best',
   closeToTray: false,
   hideDockIcon: false,
   autoUpdate: true