Add Broadcom and Aruba Modules (#3696)

* standardization of port names.

* ADD: Aruba-J9987A Module

* ADD: Broadcom Modules

* FIX: model and part_number

* FIX: model and part_number

* Error in the number of interfaces on the Palo Alto PA-410

* Erratum: PA-410

* ADD: HWG-STE SNMP Thermometer

* ADD: HWG-STE SNMP Thermometer

* Commit after comment by HarryAJC

device-types/HW-Group/HWG-STE.yml

@@ -0,0 +1,28 @@
+---
+manufacturer: HW-GROUP
+model: HWG-STE
+slug: hw-group-hwg-ste
+airflow: passive
+weight: 0.5
+weight_unit: kg
+u_height: 0.0
+comments: '[HWg-STE (PoE)](https://www.hw-group.com/files/download/man/version/hwg-ste-man_1-0-1_en.pdf)'
+is_full_depth: false
+console-server-ports:
+  - name: Serial 0/1
+    type: rj-11
+    label: SER
+    description: RJ11 (1-Wire) port for Sensors
+  - name: Serial 0/2
+    type: rj-11
+    label: T/H
+    description: RJ11 (1-Wire) port for Sensors
+power-ports:
+  - name: Power supply 5V
+    type: other
+    maximum_draw: 1
+interfaces:
+  - name: Ethernet 0/1
+    type: 100base-tx
+    mgmt_only: true
+    label: LINK

module-types/Broadcom Corporation/BCM57412-2P.yaml

@@ -1,10 +0,0 @@
----
-manufacturer: Broadcom Corporation
-model: BCM57412-2P
-part_number: BCM957412M4123C
-comments: '[BCM57412-2P - 2 x 10GbE OCP NIC](https://docs.broadcom.com/doc/957412M4123C-DS)'
-interfaces:
-  - name: pcie{module}.nic1
-    type: 10gbase-x-sfpp
-  - name: pcie{module}.nic2
-    type: 10gbase-x-sfpp

module-types/Broadcom Corporation/BCM957412-A-4120-AC.yml

@@ -0,0 +1,11 @@
+---
+manufacturer: Broadcom Corporation
+model: BCM957412-A-4120-AC
+part_number: BCM957412-A-4120-AC
+comments: '[BCM57412-2P - 2 x 10GbE PCIe](https://docs.broadcom.com/doc/957412A4120AC-DS)'
+description: Dual-Port 10 Gb/s Ethernet PCI Express Gen3 x8 Network Interface Card
+interfaces:
+  - name: Ethernet/{module}/1
+    type: 10gbase-x-sfpp
+  - name: Ethernet/{module}/2
+    type: 10gbase-x-sfpp

module-types/Broadcom Corporation/BCM957412-N-4120-C.yml

@@ -0,0 +1,11 @@
+---
+manufacturer: Broadcom Corporation
+model: BCM957412-N-4120-C
+part_number: BCM957412-N-4120-C
+comments: '[BCM57412-2P - 2 x 10GbE OCP 3.0](https://docs.broadcom.com/doc/957412N4120C-DS)'
+description: Dual-Port 10 Gb/s Ethernet PCI Express 3.0 x8 OCP 3.0 Small-Form-Factor Network Adapter
+interfaces:
+  - name: Ethernet/{module}/1
+    type: 10gbase-x-sfpp
+  - name: Ethernet/{module}/2
+    type: 10gbase-x-sfpp

module-types/Broadcom Corporation/BCM957414-A-4142-CC.yml

@@ -0,0 +1,11 @@
+---
+manufacturer: Broadcom Corporation
+model: BCM957414-A-4142-CC
+part_number: BCM957414-A-4142-CC
+comments: '[BCM57414-2P - 2 x 25GbE PCIe3](https://docs.broadcom.com/doc/957414N4140C-DS)'
+description: Dual-Port 25 Gb/s SFP28 Ethernet PCI Express 3 x8 Network Interface Card
+interfaces:
+  - name: Ethernet/{module}/1
+    type: 25gbase-x-sfp28
+  - name: Ethernet/{module}/2
+    type: 25gbase-x-sfp28

module-types/Broadcom Corporation/BCM957414-N-4140-C.yml

@@ -0,0 +1,11 @@
+---
+manufacturer: Broadcom Corporation
+model: BCM957414-N-4140-C
+part_number: BCM957414-N-4140-C
+comments: '[BCM57414-2P - 2 x 25GbE OCP 3.0](https://docs.broadcom.com/doc/957414N4140C-DS)'
+description: Dual-Port 25/10 Gb/s Ethernet PCI Express 3.0 x8 OCP 3.0 Small-Form-Factor Network Adapter
+interfaces:
+  - name: Ethernet/{module}/1
+    type: 25gbase-x-sfp28
+  - name: Ethernet/{module}/2
+    type: 25gbase-x-sfp28

module-types/Broadcom Corporation/BCM957416-A-4160-C.yml

@@ -0,0 +1,11 @@
+---
+manufacturer: Broadcom Corporation
+model: BCM957416-A-4160-C
+part_number: BCM957416-A-4160-C
+comments: '[BCM57416-2P - 2 x 10GBASE-T PCIe3](https://docs.broadcom.com/doc/957416A4160C-DS)'
+description: Dual-Port 10GBASE-T Ethernet PCI Express 3.0 x8 Network Interface Card
+interfaces:
+  - name: Ethernet/{module}/1
+    type: 10gbase-t
+  - name: Ethernet/{module}/2
+    type: 10gbase-t

module-types/Broadcom Corporation/BCM957416-N-4160-C.yml

@@ -0,0 +1,11 @@
+---
+manufacturer: Broadcom Corporation
+model: BCM957416-N-4160-C
+part_number: BCM957416-N-4160-C
+comments: '[BCM57416-2P - 2 x 10GBASE-T OCP 3.0](https://docs.broadcom.com/doc/957416N4160C-DS)'
+description: Dual-Port 10GBASE-T Ethernet PCI Express 3.0 x8 OCP 3.0 Small-Form-Factor Card
+interfaces:
+  - name: Ethernet/{module}/1
+    type: 10gbase-t
+  - name: Ethernet/{module}/2
+    type: 10gbase-t

module-types/HPE/Aruba-J9987A.yaml

@@ -0,0 +1,54 @@
+---
+manufacturer: HPE
+model: Aruba J9987A
+part_number: J9987A
+comments: HPE J9987A Aruba 24p 1000 Base-T v3 zl2 Module
+interfaces:
+  - name: '{module}/1'
+    type: 1000base-t
+  - name: '{module}/2'
+    type: 1000base-t
+  - name: '{module}/3'
+    type: 1000base-t
+  - name: '{module}/4'
+    type: 1000base-t
+  - name: '{module}/5'
+    type: 1000base-t
+  - name: '{module}/6'
+    type: 1000base-t
+  - name: '{module}/7'
+    type: 1000base-t
+  - name: '{module}/8'
+    type: 1000base-t
+  - name: '{module}/9'
+    type: 1000base-t
+  - name: '{module}/10'
+    type: 1000base-t
+  - name: '{module}/11'
+    type: 1000base-t
+  - name: '{module}/12'
+    type: 1000base-t
+  - name: '{module}/13'
+    type: 1000base-t
+  - name: '{module}/14'
+    type: 1000base-t
+  - name: '{module}/15'
+    type: 1000base-t
+  - name: '{module}/16'
+    type: 1000base-t
+  - name: '{module}/17'
+    type: 1000base-t
+  - name: '{module}/18'
+    type: 1000base-t
+  - name: '{module}/19'
+    type: 1000base-t
+  - name: '{module}/20'
+    type: 1000base-t
+  - name: '{module}/21'
+    type: 1000base-t
+  - name: '{module}/22'
+    type: 1000base-t
+  - name: '{module}/23'
+    type: 1000base-t
+  - name: '{module}/24'
+    type: 1000base-t

module-types/HPE/Aruba-J9993A.yaml

@@ -4,19 +4,19 @@ model: Aruba J9993A
 part_number: J9993A
 comments: HPE J9993A Aruba 8p 1G/10GbE SFP+ v3 zl2 Module
 interfaces:
-  - name: '{module}1'
+  - name: '{module}/1'
     type: 10gbase-x-sfpp
-  - name: '{module}2'
+  - name: '{module}/2'
     type: 10gbase-x-sfpp
-  - name: '{module}3'
+  - name: '{module}/3'
     type: 10gbase-x-sfpp
-  - name: '{module}4'
+  - name: '{module}/4'
     type: 10gbase-x-sfpp
-  - name: '{module}5'
+  - name: '{module}/5'
     type: 10gbase-x-sfpp
-  - name: '{module}6'
+  - name: '{module}/6'
     type: 10gbase-x-sfpp
-  - name: '{module}7'
+  - name: '{module}/7'
     type: 10gbase-x-sfpp
-  - name: '{module}8'
+  - name: '{module}/8'
     type: 10gbase-x-sfpp

module-types/HPE/Aruba-J9995A.yaml

@@ -2,21 +2,37 @@
 manufacturer: HPE
 model: Aruba J9995A
 part_number: J9995A
-comments: HPE Aruba J9995A 8p 1G/2.5G/5G/XGT v3 zl2 Module
+comments: HPE Aruba 8 port 1/2.5/5/10GT PoE+ v3 zl2 Module (https://www.hpe.com/psnow/doc/PSN8084196FRFR.pdf)
 interfaces:
-  - name: '{module}1'
+  - name: '{module}/1'
     type: 10gbase-t
-  - name: '{module}2'
+    poe_mode: pse
+    poe_type: type2-ieee802.3at
+  - name: '{module}/2'
     type: 10gbase-t
-  - name: '{module}3'
+    poe_mode: pse
+    poe_type: type2-ieee802.3at
+  - name: '{module}/3'
     type: 10gbase-t
-  - name: '{module}4'
+    poe_mode: pse
+    poe_type: type2-ieee802.3at
+  - name: '{module}/4'
     type: 10gbase-t
-  - name: '{module}5'
+    poe_mode: pse
+    poe_type: type2-ieee802.3at
+  - name: '{module}/5'
     type: 10gbase-t
-  - name: '{module}6'
+    poe_mode: pse
+    poe_type: type2-ieee802.3at
+  - name: '{module}/6'
     type: 10gbase-t
-  - name: '{module}7'
+    poe_mode: pse
+    poe_type: type2-ieee802.3at
+  - name: '{module}/7'
     type: 10gbase-t
-  - name: '{module}8'
+    poe_mode: pse
+    poe_type: type2-ieee802.3at
+  - name: '{module}/8'
     type: 10gbase-t
+    poe_mode: pse
+    poe_type: type2-ieee802.3at